fix(action): be more restrictive on the release branch format #8052
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time a new release branch with format release/x.y.z is created, it triggers the creation of a bug report called: vx.y.z Bug Report. This works fine, but the problem we have is that it sometimes also creates bug reports in situations where we don’t want it, like when someone creates a branch called release/x.y.z-cherry-pick-swaps-content. This commit adds more restrictions in the regex in order to prevent that.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
needs-dev-review
NicolasMassart
approved these changes
Dec 8, 2023
Merged
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8052 +/- ##
=======================================
Coverage 37.14% 37.14%
=======================================
Files 1139 1139
Lines 29196 29196
Branches 2746 2746
=======================================
Hits 10846 10846
Misses 17724 17724
Partials 626 626 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.15.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every time a new release branch with format
release/x.y.zis created, it triggers the creation of a bug report called: "vx.y.z Bug Report".This works fine, but the problem we have is that it sometimes also creates bug reports in situations where we don’t want it, like when someone creates a branch called
release/x.y.z-cherry-pick-swaps-content.This fix adds more restrictions in the regex in order to prevent that.
Same PR for Extension
Related issues
Fixes: NA
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist