-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace Experimental Settings page with DS components #8091
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06a06f83-25c9-45b8-905f-2f813a8aa57d |
…to replace-settings-experimental
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you may have some commented out code that shouldn't be?
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8091 +/- ##
=======================================
Coverage 39.39% 39.39%
=======================================
Files 1220 1220
Lines 29800 29800
Branches 2831 2831
=======================================
Hits 11740 11740
Misses 17371 17371
Partials 689 689 ☔ View full report in Codecov by Sentry. |
Description
Design Resources:
https://www.figma.com/file/HHBddj8cVk2sqpL3MvecbQ/Experimental-page-in-settings-update?type=design&node-id=0-1&mode=design&t=YDpVbN1rQF9iy27r-0
https://www.figma.com/file/5nRaF62WvJOUJc925ALacm/Setting-page-DS-sync-with-Brian-follow-up?type=design&node-id=0-1&mode=design&t=QC83o4maZi5lSOn0-0
https://www.figma.com/file/MlBUrNnIXlftX4TSjqiUYg/Core-Components?type=design&node-id=1061-12936&mode=design&t=vGWvpVcXE9tOaHhr-0
https://www.figma.com/file/t4Zc6ZOA9Urw8POrCReEam/Privacy-epic-%26-update-security-and-privacy-in-settings?type=design&node-id=178-21581&mode=design&t=7vAal9KHWKtzpPV7-0
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-12-13.at.22.13.02.mp4
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-12-13.at.22.04.54.mp4
Pre-merge author checklist
Pre-merge reviewer checklist