Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to latest Token rates controller to release 7.12.4 #8156

Merged

Conversation

tommasini
Copy link
Contributor

Description

Copy of this PR

sanity check: https://recordit.co/X2MSnKAwo7

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner December 19, 2023 00:22
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/44080d97-13a7-4408-bcba-1f46bfc06728
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.12.4@de1b549). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/7.12.4    #8156   +/-   ##
=================================================
  Coverage                  ?   37.39%           
=================================================
  Files                     ?     1052           
  Lines                     ?    28173           
  Branches                  ?     2517           
=================================================
  Hits                      ?    10534           
  Misses                    ?    17040           
  Partials                  ?      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Dec 19, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
cockatiel 3.1.2 None +0 408 kB connor.peet

Copy link

socket-security bot commented Dec 19, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@tommasini
Copy link
Contributor Author

@SocketSecurity ignore cockatiel@3.1.1

@chrisleewilcox chrisleewilcox added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Dec 19, 2023
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@chrisleewilcox chrisleewilcox merged commit 296d6d5 into release/7.12.4 Dec 19, 2023
25 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/token-rates-latest-price-api-release-7-12-4 branch December 19, 2023 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@gauthierpetetin gauthierpetetin added the release-7.12.4 Issue or pull request that will be included in release 7.12.4 label Jan 2, 2024
@metamaskbot
Copy link
Collaborator

No release label at all on PR. Adding release label release-7.12.4 on PR, as PR was added to branch 7.12.4 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.4 Issue or pull request that will be included in release 7.12.4 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants