feat: SES lockdown v1.0.0 (Android Hermes) #8161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
leotm
force-pushed
the
feature/ses-1.0.0-mod-lockdown-hermes
branch
from
3569ff3
to
d8c6ce4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/ses-1.0.0-lockdown-hermes #8161 +/- ##
====================================================================
Coverage ? 39.46%
====================================================================
Files ? 1227
Lines ? 29796
Branches ? 2833
====================================================================
Hits ? 11759
Misses ? 17345
Partials ? 692 ☔ View full report in Codecov by Sentry. |
13 tasks
leotm
force-pushed
the
feature/ses-1.0.0-mod-lockdown-hermes
branch
from
d5356d7
to
85c5041
Compare
leotm
force-pushed
the
feature/ses-1.0.0-mod-lockdown-hermes
branch
from
85c5041
to
d54ac80
Compare
21 tasks
76 tasks
leotm
commented
Dec 20, 2023
| @@ -7663,7 +7663,7 @@ function tameErrorConstructor( | |||
| })() | |||
| , | |||
| // === functors[38] === | |||
| ({ imports: $h_imports, liveVar: $h_live, onceVar: $h_once, importMeta: $h____meta, }) => (function () { let ReferenceError,TypeError,Map,Set,arrayJoin,arrayMap,arrayPush,create,freeze,mapGet,mapHas,mapSet,setAdd,promiseCatch,promiseThen,values,weakmapGet,assert;$h_imports([["./commons.js", [["ReferenceError", [$h_a => (ReferenceError = $h_a)]],["TypeError", [$h_a => (TypeError = $h_a)]],["Map", [$h_a => (Map = $h_a)]],["Set", [$h_a => (Set = $h_a)]],["arrayJoin", [$h_a => (arrayJoin = $h_a)]],["arrayMap", [$h_a => (arrayMap = $h_a)]],["arrayPush", [$h_a => (arrayPush = $h_a)]],["create", [$h_a => (create = $h_a)]],["freeze", [$h_a => (freeze = $h_a)]],["mapGet", [$h_a => (mapGet = $h_a)]],["mapHas", [$h_a => (mapHas = $h_a)]],["mapSet", [$h_a => (mapSet = $h_a)]],["setAdd", [$h_a => (setAdd = $h_a)]],["promiseCatch", [$h_a => (promiseCatch = $h_a)]],["promiseThen", [$h_a => (promiseThen = $h_a)]],["values", [$h_a => (values = $h_a)]],["weakmapGet", [$h_a => (weakmapGet = $h_a)]]]],["./error/assert.js", [["assert", [$h_a => (assert = $h_a)]]]]]); | |||
| ({ imports: $h_imports, liveVar: $h_live, onceVar: $h_once, importMeta: $h____meta, }) => (function () { let ReferenceError,TypeError,Map,Set,arrayJoin,arrayMap,arrayPush,create,freeze,mapGet,mapHas,mapSet,setAdd,promiseThen,values,weakmapGet,assert;$h_imports([["./commons.js", [["ReferenceError", [$h_a => (ReferenceError = $h_a)]],["TypeError", [$h_a => (TypeError = $h_a)]],["Map", [$h_a => (Map = $h_a)]],["Set", [$h_a => (Set = $h_a)]],["arrayJoin", [$h_a => (arrayJoin = $h_a)]],["arrayMap", [$h_a => (arrayMap = $h_a)]],["arrayPush", [$h_a => (arrayPush = $h_a)]],["create", [$h_a => (create = $h_a)]],["freeze", [$h_a => (freeze = $h_a)]],["mapGet", [$h_a => (mapGet = $h_a)]],["mapHas", [$h_a => (mapHas = $h_a)]],["mapSet", [$h_a => (mapSet = $h_a)]],["setAdd", [$h_a => (setAdd = $h_a)]],["promiseThen", [$h_a => (promiseThen = $h_a)]],["values", [$h_a => (values = $h_a)]],["weakmapGet", [$h_a => (weakmapGet = $h_a)]]]],["./error/assert.js", [["assert", [$h_a => (assert = $h_a)]]]]]); | |||
|
|
|||
There was a problem hiding this comment.
only promiseCatch removed in refactor
|
leotm
changed the title
leotm
changed the title
|
closing as async/await to Promises refactors not needed move following changes into #8009 (now on latest ses@1.1.0) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
packages/ses/src/module-load.jspromiseCatchloadfrom async await to Promises or generator fnfile:///Users/<user>/Documents/GitHub/endo/packages/ses/for varying moduleSpecifiers depending on refactorError running main: Error: Cannot bundle: cannot follow module import ./src/lockdown-shim.js in compartment file:///.../endo/packages/ses/ses compartment cannot be skipped, or moduleSpecifier laterundefinedError running main: Error: Cannot bundle: cannot follow module import ./index.js in compartment file:///.../endo/packages/ses/cannot be skipped, or empty lockdown bundlefunctorsandcellspackages/ses/src/get-anonymous-intrinsics.jsRuntime
// assertDirectEvalAvailable(); // SES TypeError// addIntrinsics(tameRegExpConstructor(regExpTaming)); // SES TypeError// addIntrinsics(tameSymbolConstructor()); // Metro exception// addIntrinsics(getAnonymousIntrinsics()); // SES TypeError// completePrototypes(); // SES TypeError// whitelistIntrinsics(intrinsics, markVirtualizedNativeFunction); // SES TypeError// hardenIntrinsics(); // no error, app hangs loading, under investigationRelated issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist