-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to unable to find conversion rate when failing to get conversion rate #8184
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3679f453-e69b-444c-b8d5-2fa79ed1918a |
b87af2b
to
d82db03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8184 +/- ##
==========================================
+ Coverage 39.56% 39.60% +0.04%
==========================================
Files 1231 1232 +1
Lines 29821 29826 +5
Branches 2841 2841
==========================================
+ Hits 11800 11814 +14
+ Misses 17327 17322 -5
+ Partials 694 690 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I kicked off E2E one more time.
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61aef386-2d0e-4a63-9803-b5c89d0258bf |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Currently we are displaying "unable to load balance" whenever the app is not able to get conversion rates for an asset. To be more accurate we should update the message to say "unable to find conversion rate" for this scenario.
Related issues
Fixes: #8151
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist