refactor(ramp): skip adding order if already exists

[wachunei]

Description

This PR prevents double attempt to add order and a double navigation action when an order already exists in the state. The solution is to use a thunk that gets access to the state before dispatching the action that adds the order and calls the navigation.

Related issues

Fixes:

Manual testing steps

Completing the Buy & Sell flow must remain the same.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov-commenter]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (445ef2b) 39.65% compared to head (779203d) 39.64%.

Files	Patch %	Lines
app/components/UI/Ramp/index.tsx	0.00%	7 Missing ⚠️
...ents/UI/Ramp/buy/hooks/useHandleSuccessfulOrder.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8192      +/-   ##
==========================================
- Coverage   39.65%   39.64%   -0.01%     
==========================================
  Files        1233     1233              
  Lines       29820    29822       +2     
  Branches     2840     2841       +1     
==========================================
  Hits        11824    11824              
- Misses      17307    17309       +2     
  Partials      689      689              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0613a8d3-3f4e-40f8-95c0-1db1956224db
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[bkirb]

@wachunei LGTM I finished testing buy and sell flows

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

LGTM