Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: state initialisation in PPOMController #8281

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jan 15, 2024

Description

PPOMController state initialisation is broken. This is resulting in blockaid files being downloaded each time app is re-opened.

Related issues

Fixes: #8280

Manual testing steps

The issue is hard to test manually.

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner January 15, 2024 17:19
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Fix state initialisation in PPOMController fix: state initialisation in PPOMController Jan 15, 2024
@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E labels Jan 15, 2024
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eece4f01-3665-496b-b023-205fad8c0a0c
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b741e) 40.21% compared to head (f5ea888) 40.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8281   +/-   ##
=======================================
  Coverage   40.21%   40.21%           
=======================================
  Files        1235     1235           
  Lines       29883    29883           
  Branches     2862     2862           
=======================================
  Hits        12018    12018           
  Misses      17174    17174           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MetaMask MetaMask deleted a comment from hazemdraosha111 Jan 16, 2024
@jpuri jpuri requested a review from blackdevelopa January 16, 2024 11:42
@jpuri jpuri merged commit c13c354 into main Jan 16, 2024
26 checks passed
@jpuri jpuri deleted the ppom_ctrl_initstate_fix branch January 16, 2024 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 16, 2024
@metamaskbot metamaskbot added the release-7.16.0 Issue or pull request that will be included in release 7.16.0 label Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.16.0 Issue or pull request that will be included in release 7.16.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PPOMController state initialisation is broken
5 participants