-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: state initialisation in PPOMController #8281
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eece4f01-3665-496b-b023-205fad8c0a0c |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8281 +/- ##
=======================================
Coverage 40.21% 40.21%
=======================================
Files 1235 1235
Lines 29883 29883
Branches 2862 2862
=======================================
Hits 12018 12018
Misses 17174 17174
Partials 691 691 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
PPOMController state initialisation is broken. This is resulting in blockaid files being downloaded each time app is re-opened.
Related issues
Fixes: #8280
Manual testing steps
The issue is hard to test manually.
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist