-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1408 Native Alert Patch for Webview #8515
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8515 +/- ##
=======================================
Coverage 41.47% 41.47%
=======================================
Files 1263 1263
Lines 30605 30605
Branches 3008 3008
=======================================
Hits 12694 12694
Misses 17157 17157
Partials 754 754 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes satisfy requirements from our team. Great work!
Description
Currently on iOS when the user is promted with an alert to grant permissions for a website that has a big domain, it will hide the entire Alert message that the website is requesting.
Related issues
https://github.com/MetaMask/mobile-planning/issues/1408
Fixes:
Manual testing steps
e2e Testing
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/abb68302-f423-4084-9cd5-3fef3a0a5c7c
Screenshots/Recordings
Before:
This is the website we can use for debugging purposes: https://nfttoks.crypto.comsssssssss.go.f-secure.com.egghunter.in/camera.html
After:
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist