-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added keyboard avoiding view to bottomsheetdialog #8526
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…to fix/bottomsheet-keyboard-avoiding-view
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8526 +/- ##
==========================================
- Coverage 40.75% 40.75% -0.01%
==========================================
Files 1242 1242
Lines 30052 30055 +3
Branches 2876 2878 +2
==========================================
+ Hits 12249 12250 +1
Misses 17102 17102
- Partials 701 703 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Checked code
- Did not check local build
Missing release label release-7.16.0 on PR. Adding release label release-7.16.0 on PR and removing other release labels(release-7.17.0), as PR was cherry-picked in branch 7.16.0. |
Description
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-05.at.09.04.49.mp4
After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-05.at.08.56.21.mp4
Pre-merge author checklist
Pre-merge reviewer checklist