Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix add custom rpc detox test script #8615

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

SamuelSalas
Copy link
Contributor

Description

Currently, the tabs Popular and Custom Network in the Add Network screen are creating issues for the detox tests. Detox is not capable to Match the element with the current implementation. Also, we have found that using the byLabel Matcher also do not work as well. This issue affects both ios and android.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas self-assigned this Feb 17, 2024
@SamuelSalas SamuelSalas requested a review from a team as a code owner February 17, 2024 02:24
@SamuelSalas SamuelSalas linked an issue Feb 17, 2024 that may be closed by this pull request
@SamuelSalas SamuelSalas changed the title Fix add custom rpc detox test script fix: Fix add custom rpc detox test script Feb 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a20df64) 41.10% compared to head (dd95d33) 41.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8615   +/-   ##
=======================================
  Coverage   41.10%   41.10%           
=======================================
  Files        1248     1248           
  Lines       30417    30417           
  Branches     2969     2969           
=======================================
  Hits        12504    12504           
  Misses      17165    17165           
  Partials      748      748           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one small comment. Link the builds in your PR description

index.js Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelSalas SamuelSalas merged commit c88a502 into main Feb 17, 2024
26 checks passed
@SamuelSalas SamuelSalas deleted the fix/8601-add-custom-rpc-detox-test-script branch February 17, 2024 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Add Custom RPC Detox test script
4 participants