-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: segment migration update remaining files and remove legacy analytics #8748
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
missed change and fix unit test
b7539b6
to
28fd4c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8748 +/- ##
==========================================
+ Coverage 41.42% 41.60% +0.18%
==========================================
Files 1270 1268 -2
Lines 30832 30675 -157
Branches 3046 3046
==========================================
- Hits 12772 12763 -9
+ Misses 17296 17148 -148
Partials 764 764 ☔ View full report in Codecov by Sentry. |
3652923
to
275f566
Compare
275f566
to
262a099
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6aab77f5-fa03-4355-9c00-7bf08e1ad586 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/391d58aa-369b-4689-b777-019681ff01b9 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's sync with the team how to remove the circular dependency
Description
Segment migration:
Related issues
Fixes https://github.com/MetaMask/mobile-planning/issues/1129
Important
I added a TODO related a a dependency issue outside of the scope of this PR.
issue created for it: #8756
Manual testing steps
None, use e2e
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist