-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: state logs in the exported file with app version and build number #8768
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise🔄🔄🔄 Commit hash: 25ca368 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
just a nit about the test name (do not use "should",see guidelines) but if you want to keep it like this as the other test is also using this naming, it's probably fine.
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me.
Bitrise✅✅✅ Commit hash: d7fd8bd Note
|
Quality Gate passedIssues Measures |
Description
Adding the app versions and build number to the state logs txt file
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
IOS sim: https://recordit.co/mvaITSTtQC
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist