fix(ramp): undefined payment method

[wachunei]

Description

This PR fixes a bug on the usePaymentMethods hook that was resetting an allow list then the region object changed instead of its id, while the rest of the logic only changes by id. This was causing incomplete re-run of the logic resulting in an undefined selection of the payment method

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1416

Manual testing steps

1. Go to Buy flow
2. Reach Build Quote screen
3. Select New York
4. Reselect New York
5. Payment method must not be undefined (see recordings)

Screenshots/Recordings

Before

1416-before.mp4

After

1516-after.mp4

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

LGTM

[bkirb]

@wachunei LGTM, I reproduced the bug in main and verified the fix in this branch ✅