-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove all remaining legacy analytics native code #8829
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
and some iOS remains
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8829 +/- ##
==========================================
- Coverage 41.66% 41.66% -0.01%
==========================================
Files 1271 1271
Lines 30906 30905 -1
Branches 3088 3088
==========================================
- Hits 12877 12876 -1
Misses 17250 17250
Partials 779 779 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: 3256f16 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Bitrise✅✅✅ Commit hash: 14241b0 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
More than one release label on PR. Keeping the lowest one (release-7.18.0) on PR and removing other release labels (release-7.19.0). |
Description
Remove all Mixpanel analytics native code and dependencies.
Android
iOS
ios/MetaMask.xcodeproj
ios/mixpanel-iphone
git submoduleMM_MIXPANEL_TOKEN
in plist filesCommon
mixpanel
in all the project)remapFlaskEnvVariables
mapping ofMM_MIXPANEL_TOKEN
inscripts/build.sh
updateinjectHomePageScripts
inapp/components/Views/BrowserTab/index.js
Note
update
injectHomePageScripts
inapp/components/Views/BrowserTab/index.js
will be done in another PR as it's not mission critical and requires answers form dapp page team.see #8843
Note
.github/workflows/security-code-scanner.yml
uses a Mixpanel tocken that is different from the mobile app one. So no impact on it for the moment except that they have to update on their side as we will terminate the Segment subscription. I notified @NicholasEllul.Note
TODO added in code related to #8833
todo is an accepted issue in Sonar as there's an issue linked to it.
Related issues
Fixes #8795
Manual testing steps
NA
Screenshots/Recordings
NA
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist