-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Send ppom metrics when transaction is cancelled. #9075
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 72d6561 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9075 +/- ##
==========================================
- Coverage 45.58% 45.55% -0.04%
==========================================
Files 1276 1272 -4
Lines 31301 31238 -63
Branches 3202 3190 -12
==========================================
- Hits 14269 14229 -40
+ Misses 16186 16169 -17
+ Partials 846 840 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
code cleanup Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
09b678d
to
e474efb
Compare
Quality Gate passedIssues Measures |
Description
We should send PPOM/Blockaid metrics parameters when a transaction from wallet is rejected. Right now we only send the metrics when the transaction is approved.
Related issues
Fixes: #8824
Manual testing steps
Screenshots/Recordings
Before
no-metrics-tx-inside-wallet.mp4
After
on_cancel_metrics.mov
Pre-merge author checklist
Pre-merge reviewer checklist