feat: enable basic functionality on onboarding & settings

[frankvonhoven]

Description

This adds the MVP of the Basic Functionality feature

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2211

Manual testing steps

(Full testing steps from QA available in ticket above)

• Create a new Wallet

  a. Skip SRP

  • Should go to Onboarding Success Screen --> Default Settings --> Disable Basic Functionality

• Create a new Wallet

  a. Complete SRP

  • Should go to Onboarding Success Screen --> Default Settings --> Disable Basic Functionality

• Import a Wallet

  • Should go to Onboarding Success Screen --> Default Settings --> Disable Basic Functionality

• Settings Screen

  a. Open app to Wallet view
  b. Go to Settings > Privacy
  c. Scroll down to "General" > Basic functionality

  • Should be able to toggle Basic functionality
  • If OFF, should see Banner Alert on Wallet View

Screenshots/Recordings

New Wallet + SRP

new-wallet-yes-srp.mp4

New Wallet + Skip SRP

new-wallet-skip-srp.mp4

Import Wallet

import-wallet.mp4

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: abb998d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e74a68fc-e1a7-42b6-a443-fcdd9da973aa

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f71779d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58d77a9c-31cd-443e-956a-49231099b574

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 24f3a43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/405be03b-9e6c-4240-9537-c814cc06d635

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 15.32847% with 116 lines in your changes are missing coverage. Please review.

Project coverage is 45.48%. Comparing base (f7466da) to head (0ab42b4).
Report is 11 commits behind head on main.

Files	Patch %	Lines
app/components/Views/Success/index.tsx	6.06%	31 Missing ⚠️
app/store/sagas/index.ts	7.69%	24 Missing ⚠️
...uccess/DefaultSettings/BasicFunctionalitySheet.tsx	5.00%	19 Missing ⚠️
...pp/components/UI/ManageNetworks/ManageNetworks.tsx	7.14%	13 Missing ⚠️
...components/Views/Success/DefaultSettings/index.tsx	13.33%	13 Missing ⚠️
app/components/Nav/App/index.js	37.50%	5 Missing ⚠️
app/components/Views/AccountBackupStep1/index.js	0.00%	2 Missing ⚠️
...ents/Views/ImportFromSecretRecoveryPhrase/index.js	0.00%	2 Missing ⚠️
app/components/Views/Wallet/index.tsx	60.00%	1 Missing and 1 partial ⚠️
app/actions/settings/index.js	0.00%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9208      +/-   ##
==========================================
- Coverage   45.58%   45.48%   -0.11%     
==========================================
  Files        1289     1296       +7     
  Lines       31973    32101     +128     
  Branches     3314     3328      +14     
==========================================
+ Hits        14574    14600      +26     
- Misses      16528    16627      +99     
- Partials      871      874       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 564e998
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc3bffc9-8231-482e-b200-5b6e98863599

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 27ae298
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/def90029-7e28-427a-b368-ba6abc8b3edb

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[brianacnguyen]

Approved DS side