Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new notifications badge - [3 of 10] #9238

Merged
merged 14 commits into from
Apr 18, 2024
Merged

feat: add new notifications badge - [3 of 10] #9238

merged 14 commits into from
Apr 18, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Apr 15, 2024 •
edited
Loading

Description

This PR implements a new badge element to be used within Notifications feature.

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Apr 15, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners April 15, 2024 13:37
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 15, 2024
@Jonathansoufer Jonathansoufer requested a review from Cal-L April 15, 2024 18:41
@Jonathansoufer Jonathansoufer changed the title chore: add new notifications badge feat: add new notifications badge Apr 16, 2024
@brianacnguyen
Copy link
Contributor

@Jonathansoufer can you attach the story screenshots/videos?

brianacnguyen
brianacnguyen previously requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component looks good. Minor changes requested. Thank you for following the standards!

Cal-L
Cal-L reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/component-library/components/Badges/Badge/variants/BadgeNotifications/README.md Outdated Show resolved Hide resolved
app/component-library/components/Badges/Badge/variants/BadgeNotifications/README.md Outdated Show resolved Hide resolved
...nent-library/components/Badges/Badge/variants/BadgeNotifications/BadgeNotifications.types.ts Outdated Show resolved Hide resolved
...nent-library/components/Badges/Badge/variants/BadgeNotifications/BadgeNotifications.types.ts Outdated Show resolved Hide resolved
app/component-library/components/Badges/Badge/variants/BadgeNotifications/README.md Outdated Show resolved Hide resolved
app/component-library/components/Badges/Badge/variants/BadgeNotifications/README.md Outdated Show resolved Hide resolved
Cal-L
Cal-L reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve invalid template label + Apply Run E2E Smoke label to run e2e smoke tests after all comments are resolved

@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 37f34cd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e54d1e5-b7b0-47dc-9237-e831d3cdef9c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 17, 2024
@Jonathansoufer Jonathansoufer requested a review from Cal-L April 17, 2024 21:51
@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 35ea81b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b1a7a7d-575c-4d23-a1f9-f53cf5666094

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Cal-L
Copy link
Contributor

Cal-L commented Apr 18, 2024

E2E failure not related to this branch

Cal-L
Cal-L approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonathansoufer
Copy link
Contributor Author

Component looks good. Minor changes requested. Thank you for following the standards!

All changes addressed.

tommasini
tommasini approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jonathansoufer Jonathansoufer removed the request for review from brianacnguyen April 18, 2024 13:54
@Jonathansoufer Jonathansoufer dismissed brianacnguyen’s stale review April 18, 2024 13:54

Got two approvals already.

@Jonathansoufer Jonathansoufer merged commit 09bd863 into main Apr 18, 2024
30 of 31 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/notifications-badge-refactoring branch April 18, 2024 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 18, 2024
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. and removed team-mobile-platform labels Apr 18, 2024
@Jonathansoufer Jonathansoufer changed the title feat: add new notifications badge feat: add new notifications badge - [3 of 6] May 8, 2024
@Jonathansoufer Jonathansoufer changed the title feat: add new notifications badge - [3 of 6] feat: add new notifications badge - [3 of 8] May 8, 2024
@Jonathansoufer Jonathansoufer changed the title feat: add new notifications badge - [3 of 8] feat: add new notifications badge - [3 of 10] May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@Cal-L Cal-L Cal-L approved these changes

@brianacnguyen brianacnguyen brianacnguyen left review comments

Assignees

@Jonathansoufer Jonathansoufer

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jonathansoufer @brianacnguyen @Cal-L @tommasini @metamaskbot