-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): replace eth-json-rpc-errors with eth-rpc-errors #9253
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/eth-json-rpc-errors@2.0.2 |
74e2976
to
3113b1a
Compare
|
Indeed that would be a next step, but one thing at a time? This already requires some intervention: https://github.com/MetaMask/metamask-mobile/actions/runs/8703247441/job/23869119234?pr=9253 |
3113b1a
to
4693c3a
Compare
4693c3a
to
523b487
Compare
Quality Gate passedIssues Measures |
Description
eth-json-rpc-errors
was renamed toeth-rpc-errors
in 2020.metamask-mobile is still pulling in both packages. This removes deprecated
eth-json-rpc-errors
and replaces references witheth-rpc-errors
.Related issues
Manual testing steps
Screenshots/Recordings
Before
n/a
After
n/a
Pre-merge author checklist
Pre-merge reviewer checklist