Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): remove unused eth-json-rpc-infura #9277

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix(deps): remove unused eth-json-rpc-infura #9277

merged 1 commit into from
Apr 23, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 17, 2024 •
edited
Loading

Description

Remove unused dependency eth-json-rpc-infura@^5.1.0

Related issues

Blocked by

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 17, 2024
@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch 2 times, most recently from 5cc3248 to 6e8d180 Compare April 18, 2024 08:53
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6e8d180
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55df0ee2-60af-43c0-a8af-ce1c354504b2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch 3 times, most recently from ef49757 to 62a195f Compare April 18, 2024 20:08
@legobeat legobeat marked this pull request as ready for review April 18, 2024 20:11
@legobeat legobeat requested a review from a team as a code owner April 18, 2024 20:11
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 62a195f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/34f45c15-ca5a-4b71-bc79-633515f77f71

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Apr 18, 2024
Draft
12 tasks
@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch from 62a195f to d38bcc6 Compare April 18, 2024 21:52
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d38bcc6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d87cfb49-9506-43c0-8122-6f4fcba8ce2b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat requested review from leotm and tommasini April 18, 2024 22:15
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 18, 2024
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 18, 2024
@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch from d38bcc6 to 66356cb Compare April 19, 2024 03:15
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 66356cb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/51c51617-47c9-4608-a3af-cb278714182f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6bf504a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b712bd1a-b39b-4790-9118-ab887933e7a1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch from 6bf504a to 55d067e Compare April 22, 2024 22:55
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 55d067e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/172076b6-0647-4b6c-bee5-aaf7d0faa479

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch from 55d067e to 0b938ee Compare April 22, 2024 23:25
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0b938ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b8856708-baa6-4561-b746-b12b35fc633c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch from 0b938ee to 645d78d Compare April 22, 2024 23:57
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 645d78d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/532a53ee-35e1-42f5-a060-693c4e1a5078

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 22, 2024
@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch from 645d78d to fc3021f Compare April 23, 2024 00:34
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fc3021f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d5f0e3f-66c1-44dd-b66a-529953445cae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-eth-json-rpc-infura branch from fc3021f to 83b554d Compare April 23, 2024 01:13
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 83b554d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/32e6f1af-12b9-4c0d-93f7-b6f149d53bf1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sethkfman
sethkfman approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat merged commit aeacf12 into main Apr 23, 2024
35 checks passed
@legobeat legobeat deleted the deps-eth-json-rpc-infura branch April 23, 2024 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@leotm leotm Awaiting requested review from leotm

@tommasini tommasini Awaiting requested review from tommasini

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legobeat @sethkfman @gauthierpetetin @metamaskbot @tommasini