fix: error when re-using exising id on permissionController

[abretonc7s]

Description

This PR fixes an issue with incorrect use of the permissionController which doesn't allow re-using similar ID to create a permission request.

If a connection sends multiple request accounts, it would endup rejecting the connection and all further requests until the app is restarted.

Because the permissionController doesn't allow passing metadata, the workaround was to use the id field to link back to metadata but it eventually created the issue described above.

Future version of the permissionController have been patched from MetaMask/core#4179

Related issues

Fixes: #9308

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[andreahaku]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
41.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[andreahaku]

LGTM

[christopherferreira9]

Main test case:

• make a double connection from an SDK dapp on purpose
• The wallet can present 2 connection requests for the same ID where only one of them is approved
• The wallet is not blocked from further SDK connections

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e8d025c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f7fb792-4b6b-4c58-9750-1df2a58213f7

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[metamaskbot]

Missing release label release-7.21.0 on PR. Adding release label release-7.21.0 on PR and removing other release labels(release-7.22.0), as PR was cherry-picked in branch 7.21.0.