-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor mechanism for sending analytics events #9411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
frankvonhoven
changed the title
fix: POC in place
fix: refactor mechanism for sending analytics events
Apr 25, 2024
sethkfman
reviewed
Apr 25, 2024
sethkfman
reviewed
Apr 25, 2024
frankvonhoven
added
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-mobile-platform
labels
Apr 29, 2024
sethkfman
reviewed
Apr 29, 2024
sethkfman
reviewed
Apr 29, 2024
…sk/metamask-mobile into fix/9233-segment-anonymous-events
sethkfman
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Apr 29, 2024
metamaskbot
added
the
release-7.23.0
Issue or pull request that will be included in release 7.23.0
label
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filter out nested objects like
{ anonymous: true, value: "ETH" }
instead of a single valueETH
that are showing up in analytics events since the migration from Mixpanel to Segment.Related issues
Fixes: #9233
Manual testing steps
active_currency
as single value and not an objectScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist