Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor mechanism for sending analytics events #9411

Merged
merged 8 commits into from
Apr 29, 2024

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Apr 25, 2024

Description

Filter out nested objects like { anonymous: true, value: "ETH" } instead of a single value ETH that are showing up in analytics events since the migration from Mixpanel to Segment.

Related issues

Fixes: #9233

Manual testing steps

  1. Go to Send Page
  2. Send a transaction
  3. Should see data in analytics dashboard for active_currency as single value and not an object

Screenshots/Recordings

Before

OLD

After

NEW

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven changed the title fix: POC in place fix: refactor mechanism for sending analytics events Apr 25, 2024
@frankvonhoven frankvonhoven added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Apr 29, 2024
@frankvonhoven frankvonhoven marked this pull request as ready for review April 29, 2024 13:49
@frankvonhoven frankvonhoven requested a review from a team as a code owner April 29, 2024 13:49
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@frankvonhoven frankvonhoven merged commit 394c81e into main Apr 29, 2024
31 checks passed
@frankvonhoven frankvonhoven deleted the fix/9233-segment-anonymous-events branch April 29, 2024 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 29, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Investigate MetaMetrics anonymous event property sent to Segment
3 participants