Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix regression tests #9525

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: fix regression tests #9525

merged 1 commit into from
May 3, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented May 3, 2024

Description

This PR will fix the regression tests

The issue arose because the keyboard obscured the block explorer label, which we typically click on to dismiss the keyboard and reveal the add button. To resolve this, we opted to click on the chainId label instead.

check the regression tests here

Related issues

Fixes: #9513

Manual testing steps

  1. Go to bitruse
  2. Run regression tests

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner May 3, 2024 10:15
Copy link
Contributor

github-actions bot commented May 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a48f9d6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2bc00f9c-c29e-4d90-9bf9-5505720a522d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb removed the Run Smoke E2E Triggers smoke e2e on Bitrise label May 3, 2024
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@salimtb salimtb requested review from cortisiko and Andepande May 3, 2024 11:26
@salimtb salimtb merged commit 0d18471 into main May 3, 2024
47 of 48 checks passed
@salimtb salimtb deleted the fix-regression-tests branch May 3, 2024 15:15
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2e iOS Test Failures in Bitrise Regression Pipeline
3 participants