chore: Chore/1742 remove vault recreation log in

[Cal-L]

Description

This PR removes a condition in the Authentication service where the vault would be recreated upon first time log in (excluding password creation during wallet creation). This logic existed for backwards compatibility but was never needed since the app was always using the "original" encryption lib. Since vault recreation isn't needed, this omits the need to pass selectedAddress, which appears in most of the changes in this PR. The change in https://github.com/MetaMask/metamask-mobile/pull/9508/files#diff-75ad251e628bf4ac096dc3ad4e46d4942f61d1576784c71c6150920588b89e1eR45 already prevents this code from running. This PR further removes remaining traces.

Related issues

Fixes: #1742

Manual testing steps

App behavior remains the same as before throughout the listed scenarios:

• Create a wallet from scratch
• Immediate lock option should be respected and user is still able to log in after backgrounding/foregrounding app
• Remember me option should be respected + continues to override immediate lock timer
• Log in after killing app + reopening should work without issues
• Upgrading from before (main) -> (changes in this PR) should still allow users to log in successfully
• Vault recovery flow recovers wallet successfully

Screenshots/Recordings

• Create a wallet from scratch

wallet-creation.mov

• Immediate lock option should be respected and user is still able to log in after backgrounding/foregrounding app

immediate-lock.mov

• Remember me option should be respected + continues to override immediate lock timer

remember-me.mov

• Log in after killing app + reopening should work without issues

kill-reopen.mov

• Upgrading from before (main) -> (changes in this PR) should still allow users to log in successfully

upgrade.mov

• Vault recovery flow recovers wallet successfully

recovery.mov

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: da68a8f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb2fe358-0a8d-4ae2-950c-21dcf7d2ae73

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

E2E regression pipeline run here - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f910275e-247c-4c42-b6a6-fa975d4f74f7

[tommasini]

Awesome cleaning! It seems that can have a few more cleaning lint is failing

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
13.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Cal-L]

Latest commit just removes unused imports. Commit before that passes both smoke and regression PR ✌️

[MarioAslau]

Looks great! Great catch Cal!