Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update gas fee controller to 15.1.2 #9693

Merged
merged 27 commits into from
Jun 6, 2024
Merged

chore: update gas fee controller to 15.1.2 #9693

merged 27 commits into from
Jun 6, 2024

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented May 20, 2024 •
edited
Loading

Description

This PR upgrades gas-fee-controller from version 13 to version 15.1.2 and fixes the breaking changes associated with the upgrade.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1785

Manual testing steps

  1. Create a transaction to send tokens from one wallet to another. Verify that the gas fee looks agreeable.

Screenshots/Recordings

Regular Transactions

Before:
Screenshot 2024-05-20 at 6 04 52 PM

After:
Screenshot 2024-05-20 at 5 54 26 PM

Dapp Transaction

Before:
Screenshot 2024-05-21 at 5 59 42 PM

After:
Screenshot 2024-05-21 at 6 12 47 PM

Reported prices (app vs Etherscan)
ETH Mainnet: .00017 ETH vs 0.00017017
Linea mainnet: < .00001 ETH vs .000001 ETH
Sepolia testnet: .00023 ETH vs 0.00022519

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@kylanhurt kylanhurt changed the base branch from main to update/1781-base-controller-v5 May 21, 2024 15:46
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform labels May 21, 2024
Base automatically changed from update/1781-base-controller-v5 to main May 22, 2024 13:22
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 22, 2024
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 22, 2024
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 22, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Jun 4, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/gas-fee-controller@13.0.2

View full report↗︎

@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 4, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 5, 2024
@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 5, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@kylanhurt kylanhurt removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 5, 2024
@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 5, 2024
Cal-L
Cal-L reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the conclusion for the failing E2E for 1559 gas estimate type? Was it resolved on the API side?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 97902b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6a0b00be-ee5c-4409-86df-7432f5aabafe

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@kylanhurt
Copy link
Contributor Author

Checked migration and it appears to be working just fine 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kylanhurt kylanhurt added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9592677
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ca62d49f-b7b8-4de5-a6f6-24639b0e74f1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylanhurt kylanhurt merged commit 31fbfa4 into main Jun 6, 2024
35 checks passed
@kylanhurt kylanhurt deleted the kylan/gas-fee-controller branch June 6, 2024 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
@metamaskbot metamaskbot added the release-7.25.0 Issue or pull request that will be included in release 7.25.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-7.25.0 Issue or pull request that will be included in release 7.25.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kylanhurt @Cal-L @metamaskbot @tommasini @MarioAslau