Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: listen for updates whenever chain id or account changes #1040

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

elefantel
Copy link
Contributor

Explanation

This PR updates the MetaMaskProviderClient to listen for updates when the chainId or the selected account on the wallet is updated via the native SDK during a deeplink callback. Previously the communication was one way RN SDK -> Native SDK (fetch), this PR enables Native SDK -> RN SDK (push) via notifications.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@elefantel elefantel requested a review from a team as a code owner September 19, 2024 17:14
@elefantel elefantel self-assigned this Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.81%. Comparing base (e8d3319) to head (de2bba8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1040   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         179      179           
  Lines        4120     4120           
  Branches     1016     1016           
=======================================
  Hits         3247     3247           
  Misses        873      873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants