fix: fixes channel occupancy value not populate properly #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 177 177
Lines 3863 3863
Branches 949 949
=======================================
Hits 3349 3349
Misses 514 514 ☔ View full report in Codecov by Sentry. |
ecp4224
previously approved these changes
Jul 26, 2024
| let channelOccupancy = 0; | ||
| const now = Date.now(); | ||
|
|
||
| // Decrement the number of clients in the room |
There was a problem hiding this comment.
Suggested change
| // Decrement the number of clients in the room | |
| // Grab channel occupancy if available |
| const channelOccupancy = | ||
| (await pubClient.hget('channels', channelId)) ?? undefined; | ||
|
|
||
| const sRedisChannelOccupancy = await pubClient.hget('channels', channelId); |
There was a problem hiding this comment.
So this can be either a JSON string or a number (old format)? This function assumes this will always be a number. Does this code path need to handle both cases like the other places?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes channel occupancy value not populate properly on Redis
References
Checklist