Skip to content

update dependencies #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Jan 15, 2025
Merged

update dependencies #30

merged 40 commits into from
Jan 15, 2025

Conversation

@metalurgical
Copy link
Contributor

@metalurgical metalurgical commented Jul 30, 2024 •
edited
Loading

Merge into #29, then merge #29

@metalurgical
Copy link
Contributor Author

metalurgical commented Sep 15, 2024 •
edited
Loading

@AyushBherwani1998 Why are you replacing SFA with FND? There's a typealias already for what you're trying to change

@AyushBherwani1998
Copy link
Member

AyushBherwani1998 commented Sep 15, 2024

It was originally using the FND, but the FND network type is not compatible with loginWithJWT(SFA), but later realized FND is also required for node details. It'll require explicit conversion in loginWithJWT

@metalurgical
Copy link
Contributor Author

metalurgical commented Sep 15, 2024 •
edited
Loading

It is the same type due to the typealias. See here: https://github.com/Web3Auth/single-factor-auth-swift/blob/d9a8fd7885e37e74e61010f8fb240cbbafd1e577/Sources/SingleFactorAuth/SingleFactorAuthArgs.swift#L3

@metalurgical
Copy link
Contributor Author

metalurgical commented Sep 15, 2024

Please revert it.

@AyushBherwani1998
Copy link
Member

AyushBherwani1998 commented Sep 15, 2024 via email

@metalurgical
Copy link
Contributor Author

metalurgical commented Sep 15, 2024

Link to where you're running into the problem?

@AyushBherwani1998
Copy link
Member

AyushBherwani1998 commented Sep 15, 2024

You can try the examples here: https://github.com/Web3Auth/web3auth-core-kit-examples/tree/main/mpc-core-kit-ios.

Also, we shouldn't do this. This was done to make a better developer experience, and having the same enum across all platform SDKs. MetaMask/single-factor-auth-swift@e9ae8be

Maybe we can have a call tomorrow to discuss this change? cc:// @shahbaz17

@metalurgical
Copy link
Contributor Author

metalurgical commented Sep 15, 2024

The quick start compiles, see here:
Web3Auth/mpc-core-kit-examples@c32ce00

@metalurgical
Copy link
Contributor Author

metalurgical commented Nov 21, 2024 •
edited
Loading

Closes #28
Closes #27
Closes #31

ieow
ieow reviewed Dec 10, 2024
View reviewed changes
metalurgical
metalurgical commented Jan 3, 2025
View reviewed changes
metalurgical
metalurgical commented Jan 8, 2025
View reviewed changes
himanshuchawla009
himanshuchawla009 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, need clarification for one comment

This was referenced Jan 13, 2025
Merged
Closed
metalurgical
metalurgical commented Jan 15, 2025
View reviewed changes
@metalurgical metalurgical merged commit a9d23ff into feat/signer Jan 15, 2025
1 check passed
This was referenced Jan 16, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ieow ieow ieow left review comments

+2 more reviewers

@AyushBherwani1998 AyushBherwani1998 AyushBherwani1998 left review comments

@himanshuchawla009 himanshuchawla009 himanshuchawla009 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@metalurgical @AyushBherwani1998 @himanshuchawla009 @ieow