Remove unused assert dependency
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`assert` is a Node.js built-in module, so that will take priority over the `assert` dependency whenever it is imported. `browserify` and other bundlers will inject this package whenever it seems `assert` imported, but they will use their own versions, not the one specified here. In practice, this is entirely unused.
darkwing
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertis a Node.js built-in module, so that will take priority over theassertdependency whenever it is imported.browserifyand other bundlers will inject this package whenever it seemsassertimported, but they will use their own versions, not the one specified here. In practice, this is entirely unused.