Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0 #48

Merged
merged 5 commits into from
Oct 3, 2023
Merged

2.0.0 #48

merged 5 commits into from
Oct 3, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 25, 2023 •
edited by legobeat
Loading

This is the release candidate for version 2.0.0.

Blocked by

github-actions and others added 2 commits September 25, 2023 11:03
@legobeat legobeat marked this pull request as ready for review September 25, 2023 11:06
@legobeat legobeat requested a review from a team as a code owner September 25, 2023 11:06
@legobeat legobeat requested review from mcmire, kumavis, a team and FrederikBolding September 25, 2023 11:16
Mrtenz
Mrtenz requested changes Sep 25, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@legobeat @Mrtenz
Update CHANGELOG.md
ff7bca9 
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
@legobeat legobeat requested a review from Mrtenz September 25, 2023 11:52
Gudahtt
Gudahtt requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous v1.2.0 release failed because the publishing action is meant for Yarn v3 but this is still on Yarn v1. We'll need to fix that before this release as well

@legobeat legobeat mentioned this pull request Sep 28, 2023
Merged
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lavamoat/preinstall-always-fail 1.0.3 None +0 2.87 kB boneskull
@ethersproject/providers 5.7.2 network +23 2.9 MB ricmoo

🚮 Removed packages: nonce-tracker@1.2.0

@socket-security
Copy link

socket-security bot commented Oct 2, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: bech32@1.1.4, @lavamoat/preinstall-always-fail@1.0.3, @ethersproject/web@5.7.1, ws@7.4.6

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor

legobeat commented Oct 2, 2023 

@SocketSecurity ignore @ethersproject/web@5.7.1
@SocketSecurity ignore ws@7.4.6

network access ok

@legobeat
Copy link
Contributor

legobeat commented Oct 2, 2023 

@SocketSecurity ignore bech32@1.1.4
@SocketSecurity ignore @lavamoat/preinstall-always-fail@1.0.3

new author ok

@legobeat legobeat requested a review from Gudahtt October 2, 2023 09:30
@legobeat
Copy link
Contributor

legobeat commented Oct 2, 2023

The previous v1.2.0 release failed because the publishing action is meant for Yarn v3 but this is still on Yarn v1. We'll need to fix that before this release as well

@Gudahtt #49

mcmire
mcmire approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Gudahtt
Gudahtt approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit a607bc5 into main Oct 3, 2023
@legobeat legobeat deleted the release/2.0.0 branch October 3, 2023 02:27
legobeat added a commit to legobeat/nonce-tracker that referenced this pull request Oct 3, 2023
@legobeat
Revert "2.0.0 (MetaMask#48)"
1aa858c 
This reverts commit a607bc5 (MetaMask#48).
Release failed due to changelog lint. Will be followed up with a fixed
publish of the same package.
@legobeat legobeat mentioned this pull request Oct 3, 2023
Merged
legobeat added a commit that referenced this pull request Oct 3, 2023
@legobeat
Revert "2.0.0 (#48)" (#50)
211c7ce 
This reverts commit a607bc5 (#48).
Release failed due to changelog lint. Will be followed up with a fixed publish of the same package.
@legobeat legobeat mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@kumavis kumavis kumavis approved these changes

@mcmire mcmire mcmire approved these changes

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legobeat @mcmire @kumavis @Gudahtt @Mrtenz