Replace Ethers with @metamask/eth-query #59
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that a recent change to switch from `ethjs-query` to Ethers has caused a regression: when the network is switched, `this.web3` still points to the previous network. This happens because Web3Provider saves a copy of the `sendAsync` method on the given provider, so even if `nonce-tracker` is given a provider proxy, `this.web3` still has a reference to the `sendAsync` method from the previous provider object. This is a common problem with Ethers. Although Ethers has some nice features, we don't need to pull it in here, and we can use `@metamask/eth-query` (which provides TypeScript support, unlike `@metamask/ethjs-query`) instead. We do lose one feature of Ethers, which is that it automatically converts response data for requests to the appropriate types, but we can make use of `@metamask/utils` to help with this.
Gudahtt
reviewed
Nov 24, 2023
| `nonce-tracker - baseCount is not an integer - got: (${typeof baseCount}) "${baseCount}"`, | ||
| ); | ||
| const baseCountAsHex = await new Promise<string>((resolve, reject) => { | ||
| this.ethQuery.sendAsync<string[], string>( |
There was a problem hiding this comment.
Nit: We could drop ethQuery here and call the provider directly:
Suggested change
| this.ethQuery.sendAsync<string[], string>( | |
| this.provider.sendAsync<string[], string>( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that a recent change to switch from
ethjs-queryto Ethers has caused a regression: when the network is switched,this.web3still points to the previous network. This happens because Web3Provider saves a copy of thesendAsyncmethod on the given provider, so even ifnonce-trackeris given a provider proxy,this.web3still has a reference to thesendAsyncmethod from the previous provider object.This is a common problem with Ethers. Although Ethers has some nice features, we don't need to pull it in here, and we can use
@metamask/eth-query(which provides TypeScript support, unlike@metamask/ethjs-query) instead. We do lose one feature of Ethers, which is that it automatically converts response data for requests to the appropriate types, but we can make use of@metamask/utilsto help with this.Fixes #58.