Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove @metamask/eth-block-tracker peer dependency #85

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 14, 2025

The @metamask/eth-block-tracker dependency has been removed in favor of inlining the subset of the BlockTracker type that this library depends upon. This makes this package easier to install, and reduces complexity of dependency management for the wallet clients.

@Gudahtt Gudahtt force-pushed the remove-eth-block-tracker-peer-dependency branch from 046d67d to 0288658 Compare January 14, 2025 21:35
The `@metamask/eth-block-tracker` dependency has been removed in favor
of inlining the subset of the `BlockTracker` type that this library
depends upon. This makes this package easier to install, and reduces
complexity of dependency management for the wallet clients.
@Gudahtt Gudahtt force-pushed the remove-eth-block-tracker-peer-dependency branch from 0288658 to 89ba0a3 Compare January 14, 2025 21:37
@Gudahtt Gudahtt marked this pull request as ready for review January 14, 2025 21:41
@Gudahtt Gudahtt requested a review from a team as a code owner January 14, 2025 21:41
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from one thing!

src/NonceTracker.ts Outdated Show resolved Hide resolved
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 91a04c5 into main Jan 14, 2025
24 checks passed
@Gudahtt Gudahtt deleted the remove-eth-block-tracker-peer-dependency branch January 14, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants