Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.1.0 #86

Merged
merged 2 commits into from
Jan 17, 2025
Merged

6.1.0 #86

merged 2 commits into from
Jan 17, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 6.1.0.

github-actions and others added 2 commits January 14, 2025 22:32
@Gudahtt Gudahtt marked this pull request as ready for review January 14, 2025 22:36
@Gudahtt Gudahtt requested a review from a team as a code owner January 14, 2025 22:36
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you using a minor bump to highlight the removal more so than usual?

@Gudahtt
Copy link
Member

Gudahtt commented Jan 15, 2025

Hmm, no, minor was what I always use for changes. Patch for bug fixes.

Minor seems appropriate here given the nature of the change as well; users of the package might want to consider removing this dependency if it was added just to satisfy the peer dependency requirement. So it's in a similar vein as other minor changes: no change strictly needed, but you might want to review changes to look for opportunities for improvement/cleanup.

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gudahtt Gudahtt merged commit c214dbd into main Jan 17, 2025
24 checks passed
@Gudahtt Gudahtt deleted the release/6.1.0 branch January 17, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants