Skip to content

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 5, 2023

Blocked by:

@legobeat legobeat requested a review from a team as a code owner September 5, 2023 21:15
@legobeat legobeat requested review from a team September 5, 2023 21:16
@legobeat legobeat marked this pull request as draft September 5, 2023 21:18
@socket-security
Copy link

socket-security bot commented Sep 5, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
end-of-stream 1.4.4...1.4.0 None +0/-0 5.8 kB mafintosh
pump 1.0.3...2.0.1 None +1/-1 13.2 kB mafintosh
readable-stream 2.3.7...3.6.2 None +0/-0 124 kB matteo.collina

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 5, 2023
@legobeat legobeat mentioned this pull request Sep 5, 2023
"eslint-plugin-prettier": "^3.4.0",
"prettier": "^2.3.0",
"pump": "^1.0.2",
"pump": "^2.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legobeat Could we use stream / readable-stream instead?

pump should equal pipeline and end-of-stream should equal finished

https://github.com/nodejs/readable-stream/blob/main/lib/stream.js#L100-L103

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node engines update and the readable-stream bump are interdependent so closing this in favor of #41 , where pump and end-of-stream are now removed.

@legobeat
Copy link
Contributor Author

Closing in favor of:

@legobeat legobeat closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants