Skip to content

Conversation

@legobeat
Copy link
Contributor

non-breaking maintenance updates. In particular, updates Typescript to 4.8.4.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 28, 2023
@socket-security
Copy link

socket-security bot commented Sep 28, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
typescript 4.8.4 filesystem +0 68.8 MB typescript-bot
tape 4.13.3...4.17.0 environment +57/-26 4.91 MB ljharb
@typescript-eslint/eslint-plugin 4.26.0...5.62.0 None +27/-19 78.8 MB jameshenry
@typescript-eslint/parser 4.26.0...5.62.0 None +18/-16 74.1 MB jameshenry
eslint-plugin-prettier 3.4.0...3.4.1 None +7/-8 3.61 MB bpscott
eslint 7.27.0...7.32.0 None +6/-6 3.55 MB eslintbot
eslint-plugin-import 2.23.4...2.26.0 None +65/-58 9.25 MB ljharb

🚮 Removed packages: prettier@2.3.0

@socket-security
Copy link

socket-security bot commented Sep 28, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: hasown@2.0.0, defined@1.0.1, define-properties@1.2.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore defined@1.0.1

new author ok

@legobeat legobeat marked this pull request as ready for review September 28, 2023 04:38
@legobeat legobeat requested a review from a team as a code owner September 28, 2023 04:38
@legobeat legobeat requested review from a team October 2, 2023 08:50
@legobeat legobeat requested a review from a team October 24, 2023 00:27
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore hasown@2.0.0

new author ok

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore define-properties@1.2.1

unpublished (?)

@legobeat legobeat requested a review from abretonc7s October 24, 2023 09:18
@legobeat legobeat requested a review from Mrtenz October 24, 2023 09:58
@legobeat legobeat mentioned this pull request Oct 24, 2023
2 tasks
Mrtenz
Mrtenz previously approved these changes Oct 24, 2023
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "^2.23.4",
"eslint-plugin-import": "2.26.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use ~2.26.0 elsewhere.

Copy link
Contributor Author

@legobeat legobeat Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can loosen this when rest of eslint packages are bumped

@legobeat legobeat merged commit 210d605 into MetaMask:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants