test: Migrate all packages from jest to vitest
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
changed the title
vitest
This comment was marked as resolved.
This comment was marked as resolved.
rekmarks
changed the title
vitestjest to vitest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest's ESM support sucks (ref) and is held up on some interminable issues related to Node VMs (ref). I was impressed with
viteandvitestfollowing my experience implementing #8, and after I discovered thatvitesthas a browser mode for unit tests—which will ultimately allow us to test undersesin an actual browser environment—I was sold.This migrates the entire repo from
jesttovitest. They work very similarly, exceptvitesthas a number of benefits overjest, such as not polluting the global namespace by default. I tried running some tests underseswith lockdown in the browser, and it worked perfectly. However, it's held up on rewriting tests that rely on JSDOM, so we're tracking that work in #12.Testing
To test this locally, just try running the
package.jsontest scripts in any package, including the root.