Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Aug 19, 2024

Closes #24

Bumps TypeScript, ESLint, and @metamask/eslint-config-* to the latest available versions. Makes necessary fixes to please our updated linter.

@socket-security

This comment was marked as resolved.

Base automatically changed from rekm/lockfile-reset to main August 19, 2024 14:23
@rekmarks rekmarks marked this pull request as ready for review August 19, 2024 14:35
@rekmarks rekmarks requested a review from a team as a code owner August 19, 2024 14:35
@rekmarks rekmarks force-pushed the rekm/bump-typescript branch from 6440771 to 388e0a1 Compare August 19, 2024 14:36
Copy link
Contributor

@SMotaal SMotaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the following note:

I went over the changed files in glimpses as the checks are passing. My thinking is any possible concerns may only show up and be addressed separately down the road.

If that is okay with you, please do land, or otherwise, please re-request my review.

@rekmarks rekmarks merged commit ec4bd02 into main Aug 19, 2024
@rekmarks rekmarks deleted the rekm/bump-typescript branch August 19, 2024 16:34
SMotaal added a commit that referenced this pull request Aug 22, 2024
SMotaal added a commit that referenced this pull request Aug 22, 2024
This bumps `typescript@5.5.4` once again, reapplying changes from #23
which were accidentally reverted in #16.

This also applies minor patches to `packages/shims/scripts/bundle.js` to
prevent a known failure in `node@18`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump TypeScript to v5.5

3 participants