generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: reject promises on connection loss #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
917b7a8 to
bfd7d4a
Compare
f95a717 to
9750de6
Compare
rekmarks
reviewed
Dec 15, 2025
9750de6 to
54d9636
Compare
rekmarks
requested changes
Dec 16, 2025
Member
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some questions / comments.
rekmarks
previously approved these changes
Dec 16, 2025
Member
rekmarks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but see the robot's most recent review.
rekmarks
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686
This PR does the following:
maxRetryAttemptsandmaxQueueas configurable options for remote communications initialization, converts therelaysparameter to anoptionsobject for future extensibility.maxRetryAttemptswas not being respected due toresetBackoffbeing called too early in the reconnection flow.Note
Reject promises when remote connections are abandoned; switch remote comms init to options (relays/maxRetryAttempts/maxQueue) and tighten reconnection/backoff behavior across stack.
remoteGiveUpRPC (kernel-remote) and propagate from server to kernel;RemoteManagerrejects pending URL redemptions and all promises decided by the remote on give-up.initRemoteCommsto acceptRemoteCommsOptions(relays,maxRetryAttempts,maxQueue); persist relays; updatePlatformServices/types accordingly.maxRetryAttempts, reset backoff only after successful flush, queue flushing merges hints, intentional close handling, wake detector backoff reset;ConnectionFactoryacceptsmaxRetryAttempts.getPromisesByDecidernow usesEndpointId.remoteGiveUp(client callback, server forwards via RPC).remoteManager.cleanup()on stop; worker init useskernel.initRemoteComms({ relays }).Written by Cursor Bugbot for commit 232de02. This will update automatically on new commits. Configure here.