fix: Incomplete URL scheme check #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
autofix/alert-1-051a239a5a
branch
from
0f3c1a6 to
57aadb1
Compare
legobeat
changed the title
NicholasEllul
approved these changes
Oct 23, 2024
| @@ -87,7 +87,7 @@ function setupOpenSelfInNewTabLink() { | |||
| */ | |||
| function isValidSuspectHref(href: string) { | |||
| /* eslint-disable-next-line */ | |||
| const disallowedProtocols = ['javascript:']; | |||
| const disallowedProtocols = ['javascript:', 'data:', 'vbscript:']; | |||
legobeat
force-pushed
the
autofix/alert-1-051a239a5a
branch
from
9b25752 to
f2eb0a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the problem, we need to extend the
disallowedProtocolsarray to includedata:andvbscript:schemes. This ensures that URLs with these schemes are also considered invalid, thereby enhancing the security of the URL validation logic.disallowedProtocolsarray to includedata:andvbscript:schemes.isValidSuspectHreffunction correctly identifies these schemes as disallowed.Related