Accidental breaking change introduced in v18.1.0 #389
Assignees
Labels
Comments
Gudahtt
added a commit
that referenced
this issue
Nov 27, 2024
The `MetaMaskInpageProvider` type was mistakenly typed to require the `jsonRpcStreamName` as a constructor parameter, despite the author clearly intending this to be optional. This type error was fixed. This type error motivated a different bug, which is that validation for `jsonRpcStreamName` was added to `initializeInapgeProvider` in #381, constituting an undocumented breaking change (currently blocking us from updating this package in `metamask-extension`). This validation has been removed now that it's no longer needed. Fixes #389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This PR was included in v18.1.0: #381
It included a breaking change to
initializeProvider, namely that the parameterjsonRpcStreamNameis now required when it was functionally optional before. The change was made to fix a type error; theMetaMaskInpageProvidermistakenly had typed that parameter is required, but the intention was for it to be optional.The text was updated successfully, but these errors were encountered: