Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isEnabled and isApproved _metamask methods #112

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Remove isEnabled and isApproved _metamask methods #112

merged 2 commits into from
Nov 30, 2020

Conversation

rekmarks
Copy link
Member

Per upcoming breaking changes, removes _metamask.isEnabled and _metamask.isApproved.

@rekmarks rekmarks requested a review from a team as a code owner November 24, 2020 20:53
@rekmarks rekmarks requested a review from brad-decker November 24, 2020 20:53
Gudahtt
Gudahtt approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks
Copy link
Member Author

CI passes: https://app.circleci.com/pipelines/github/MetaMask/inpage-provider/376/workflows/28cb3339-8bcf-4ede-9ff1-e887d15f11e0

@rekmarks rekmarks merged commit 607b9f0 into main Nov 30, 2020
@rekmarks rekmarks deleted the remove-deprecated-experimental-methods branch November 30, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@brad-decker brad-decker Awaiting requested review from brad-decker

Assignees
No one assigned
Labels
2020-breaking-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt