Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests to TypeScript #167

Merged
merged 3 commits into from
May 6, 2021
Merged

Migrate tests to TypeScript #167

merged 3 commits into from
May 6, 2021

Conversation

shanejonas
Copy link
Contributor

fixes #147

@shanejonas shanejonas requested a review from a team as a code owner May 5, 2021 23:08
@rekmarks rekmarks self-assigned this May 5, 2021
@rekmarks rekmarks changed the title move tests to typescript Migrate tests to TypeScript May 6, 2021
rekmarks
rekmarks requested changes May 6, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise be to Hejlsberg for as any!

Just a couple of requests.

jest.config.js Show resolved Hide resolved
src/mocks/DuplexStream.ts Outdated Show resolved Hide resolved
rekmarks
rekmarks approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanejonas shanejonas merged commit 1a668f1 into main May 6, 2021
@shanejonas shanejonas deleted the move-tests-to-ts branch May 6, 2021 21:03
@snyk-bot snyk-bot mentioned this pull request Jun 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees

@rekmarks rekmarks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate tests to typescript
2 participants
@shanejonas @rekmarks