Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move @types/ packages from deps to devDeps #259

Merged
merged 1 commit into from
May 10, 2023
Merged

move @types/ packages from deps to devDeps #259

merged 1 commit into from
May 10, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat force-pushed the deps-move-types-to-devdeps branch from 86f8921 to 821d1cd Compare May 10, 2023 06:39
@legobeat legobeat marked this pull request as ready for review May 10, 2023 06:39
@legobeat legobeat requested a review from a team as a code owner May 10, 2023 06:39
@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 10, 2023
mcmire
mcmire approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I don't think these types are necessary to use this package in a TypeScript project.

@legobeat legobeat merged commit 41baf7f into MetaMask:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire