Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll back to production API; fixup #29

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Roll back to production API; fixup #29

merged 3 commits into from
Apr 17, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Apr 5, 2020 •
edited
Loading

This PR rolls back to the Provider API currently in production.

  • Un-deprecate sendAsync
  • Deprecate send; restore its API to what's currently in production
  • Removes makeThenable and related tests
    • Disable unit tests for CI, because those were all the tests we had
    • Adding unit tests for index.jsis still a TODO
  • Minor code reorganization and fixup

@rekmarks rekmarks requested a review from Gudahtt April 5, 2020 17:16
@rekmarks rekmarks changed the title Add request method; deprecate send; fixup Rull back to production API; fixup Apr 6, 2020
@rekmarks rekmarks changed the title Rull back to production API; fixup Roll back to production API; fixup Apr 6, 2020
@rekmarks rekmarks requested a review from whymarrh April 6, 2020 17:51
@rekmarks rekmarks mentioned this pull request Apr 13, 2020
Merged
Gudahtt
Gudahtt reviewed Apr 17, 2020
View reviewed changes
.eslintrc.js Show resolved Hide resolved
index.js Show resolved Hide resolved
Gudahtt
Gudahtt approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 119f686 into master Apr 17, 2020
@rekmarks rekmarks deleted the 1193-updates branch April 17, 2020 22:04
@Gudahtt Gudahtt mentioned this pull request Apr 22, 2020
Merged
@jiexi jiexi mentioned this pull request Oct 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt