Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send undefined params #290

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Don't send undefined params #290

merged 1 commit into from
Nov 15, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 15, 2023

undefined is not valid JSON and isn't supported by our underlying json-rpc-engine.

@Mrtenz Mrtenz requested a review from a team as a code owner November 15, 2023 15:19
Gudahtt
Gudahtt approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mcmire
mcmire approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logical to me.

@Mrtenz Mrtenz merged commit d5d5de4 into main Nov 15, 2023
17 checks passed
@Mrtenz Mrtenz deleted the mrtenz/no-undefined branch November 15, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mrtenz @mcmire @FrederikBolding @Gudahtt