Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip params if null is passed #292

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Strip params if null is passed #292

merged 2 commits into from
Nov 22, 2023

Conversation

FrederikBolding
Copy link
Member

Treat params: null the same as params: undefined. Stripping it from the input and simplifying the validation further along in the stack.

@FrederikBolding FrederikBolding requested a review from a team as a code owner November 22, 2023 09:21
Mrtenz
Mrtenz previously approved these changes Nov 22, 2023
View reviewed changes
@FrederikBolding FrederikBolding merged commit b3d0506 into main Nov 22, 2023
17 checks passed
@FrederikBolding FrederikBolding deleted the fb/dont-send-null branch November 22, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrederikBolding @Mrtenz