-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repository to match module template (February 2024) #296
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/debug@2.6.9 Network access is ok. Not used in production. @SocketSecurity ignore npm/validate-npm-package-name@5.0.0 New authors seem ok. @SocketSecurity ignore npm/foreground-child@3.1.1 Shell access ok. Not used in production. @SocketSecurity ignore npm/esbuild@0.19.12 Network / shell access is expected. @SocketSecurity ignore npm/tsup@7.3.0 Deprecated is ok. Shouldn't be an issue in our case. @SocketSecurity ignore npm/@lavamoat/preinstall-always-fail@2.0.0 Script is expected. |
@@ -1,4 +1,4 @@ | |||
# Lines starting with '#' are comments. | |||
# Each line is a file pattern followed by one or more owners. | |||
|
|||
* @MetaMask/devs | |||
* @MetaMask/engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub seems to think this doesn't exist. Does the group need to be added manually to the repo or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I already asked @Gudahtt to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the CODEOWNERS change has been resolved
This updates the repository to match the module template as of February 2024. This repo hasn't been updated in a while, so there's quite a few changes. The most notable changes are:
.nvmrc
Node versions, to reduce the number of jobs.tsup
, and includes a ESM build.