Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository to match module template (February 2024) #296

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Feb 26, 2024

This updates the repository to match the module template as of February 2024. This repo hasn't been updated in a while, so there's quite a few changes. The most notable changes are:

  • The GitHub workflows were updated to use the latest versions of the publishing actions, including a Slack message for publishing.
  • Some actions now only run on the .nvmrc Node versions, to reduce the number of jobs.
  • The Yarn allow-scripts plugin was updated, and the constraints plugin was added.
  • The package is now built with tsup, and includes a ESM build.

@Mrtenz Mrtenz requested a review from a team as a code owner February 26, 2024 11:10
Copy link

socket-security bot commented Feb 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@esbuild/android-arm@0.19.12 None 0 11.5 MB evanw
npm/@esbuild/android-arm64@0.19.12 None 0 9.83 MB evanw
npm/@esbuild/android-x64@0.19.12 None 0 11.5 MB evanw
npm/@esbuild/darwin-arm64@0.19.12 None 0 9.76 MB evanw
npm/@esbuild/darwin-x64@0.19.12 None 0 10.2 MB evanw
npm/@esbuild/freebsd-arm64@0.19.12 None 0 8.85 MB evanw
npm/@esbuild/freebsd-x64@0.19.12 None 0 9.61 MB evanw
npm/@esbuild/linux-arm@0.19.12 None 0 9.18 MB evanw
npm/@esbuild/linux-arm64@0.19.12 None 0 8.85 MB evanw
npm/@esbuild/linux-ia32@0.19.12 None 0 9.14 MB evanw
npm/@esbuild/linux-loong64@0.19.12 None 0 9.37 MB evanw
npm/@esbuild/linux-mips64el@0.19.12 None 0 10.4 MB evanw
npm/@esbuild/linux-ppc64@0.19.12 None 0 9.18 MB evanw
npm/@esbuild/linux-riscv64@0.19.12 None 0 9.11 MB evanw
npm/@esbuild/linux-s390x@0.19.12 None 0 10 MB evanw
npm/@esbuild/linux-x64@0.19.12 None 0 9.6 MB evanw
npm/@esbuild/netbsd-x64@0.19.12 None 0 9.59 MB evanw
npm/@esbuild/openbsd-x64@0.19.12 None 0 9.62 MB evanw
npm/@esbuild/sunos-x64@0.19.12 None 0 9.59 MB evanw
npm/@esbuild/win32-arm64@0.19.12 None 0 8.98 MB evanw
npm/@esbuild/win32-ia32@0.19.12 None 0 9.45 MB evanw
npm/@esbuild/win32-x64@0.19.12 None 0 9.81 MB evanw
npm/@isaacs/cliui@8.0.2 None +11 247 kB isaacs
npm/@lavamoat/aa@4.0.1 filesystem Transitive: environment +6 249 kB naugtur
npm/@lavamoat/allow-scripts@3.0.2 environment, filesystem, shell Transitive: network +123 7.72 MB boneskull
npm/@lavamoat/preinstall-always-fail@2.0.0 None 0 3.25 kB naugtur
npm/@metamask/eslint-config-jest@12.1.0 Transitive: environment, eval, filesystem, network, shell, unsafe +444 125 MB metamaskbot
npm/@metamask/eslint-config-nodejs@12.1.0 Transitive: environment, eval, filesystem, network, shell, unsafe +184 31.3 MB metamaskbot
npm/@metamask/eslint-config-typescript@12.1.0 Transitive: environment, eval, filesystem, network, shell, unsafe +206 104 MB metamaskbot
npm/@metamask/eslint-config@12.2.0 Transitive: environment, eval, filesystem, network, shell, unsafe +175 29.6 MB metamaskbot
npm/@npmcli/agent@2.2.1 environment, network +11 1.15 MB npm-cli-ops
npm/@npmcli/fs@3.1.0 filesystem +2 136 kB lukekarrys
npm/@npmcli/git@5.0.4 filesystem Transitive: environment, shell +18 804 kB npm-cli-ops
npm/@npmcli/package-json@5.0.0 filesystem Transitive: environment, shell +56 3.43 MB npm-cli-ops
npm/@npmcli/promise-spawn@7.0.1 environment, shell Transitive: filesystem +2 62.5 kB npm-cli-ops
npm/@npmcli/run-script@7.0.4 environment Transitive: filesystem, network, shell +105 6.86 MB npm-cli-ops
npm/@pkgjs/parseargs@0.11.0 None 0 74.2 kB oss-bot
npm/abbrev@2.0.0 None 0 4.83 kB lukekarrys
npm/agentkeepalive@4.3.0 network Transitive: environment, eval +3 80.4 kB fengmk2
npm/ansi-regex@6.0.1 None 0 5.67 kB qix
npm/any-promise@1.3.0 None 0 22.2 kB kevinbeaty
npm/bin-links@4.0.3 filesystem +6 142 kB npm-cli-ops
npm/builtins@5.0.1 None +2 114 kB juliangruber
npm/bundle-require@4.0.2 environment, filesystem, unsafe Transitive: network, shell +24 213 MB egoist
npm/cac@6.7.14 None 0 81.8 kB egoist
npm/cacache@18.0.2 filesystem Transitive: environment, shell +51 3.53 MB npm-cli-ops
npm/chokidar@3.6.0 environment, filesystem +14 531 kB paulmillr
npm/debug@2.6.9 environment, filesystem, network +1 57.5 kB tootallnate
npm/eastasianwidth@0.2.0 None 0 13.6 kB komagata
npm/emoji-regex@9.2.2 None 0 97.9 kB google-wombot
npm/esbuild@0.19.12 environment, filesystem, network, shell +22 213 MB evanw
npm/eslint-plugin-es@4.1.0 Transitive: environment, eval, filesystem, shell, unsafe +93 11.4 MB mysticatea
npm/eslint-plugin-n@15.7.0 filesystem Transitive: environment, eval, shell, unsafe +105 12.5 MB weiran.zsd
npm/eslint-plugin-promise@6.1.1 Transitive: environment, eval, filesystem, shell, unsafe +90 10.7 MB eslint-community-bot
npm/eslint-utils@3.0.0 Transitive: environment, eval, filesystem, shell, unsafe +91 11 MB mysticatea
npm/foreground-child@3.1.1 shell Transitive: environment, filesystem +6 112 kB isaacs
npm/fs-minipass@3.0.3 filesystem +1 299 kB npm-cli-ops
npm/glob@10.3.10 Transitive: environment, filesystem, shell +27 2.86 MB isaacs
npm/has@1.0.4 None 0 3.02 kB tarruda
npm/hosted-git-info@7.0.1 None +1 485 kB npm-cli-ops
npm/jackspeak@2.3.6 environment +13 574 kB isaacs
npm/joycon@3.1.1 environment, filesystem 0 14 kB egoist
npm/lilconfig@3.1.1 filesystem 0 17.7 kB antonk52
npm/load-tsconfig@0.2.5 None 0 17.1 kB egoist
npm/lodash.sortby@4.7.0 None 0 75.8 kB jdalton
npm/lru-cache@10.2.0 None 0 458 kB isaacs
npm/make-fetch-happen@13.0.0 network Transitive: environment, filesystem, shell +73 4.62 MB npm-cli-ops
npm/minipass-collect@2.0.1 None +1 290 kB isaacs
npm/minipass-fetch@3.0.4 environment, network +5 522 kB npm-cli-ops
npm/minipass@7.0.4 None 0 285 kB isaacs
npm/mz@2.7.0 filesystem, network, shell +4 52 kB jongleberry
npm/node-gyp@10.0.1 environment, shell Transitive: filesystem, network +82 6.5 MB lukekarrys
npm/nopt@7.2.0 None +1 31 kB npm-cli-ops
npm/normalize-package-data@6.0.0 None +12 763 kB npm-cli-ops
npm/npm-install-checks@6.3.0 None +2 116 kB npm-cli-ops
npm/npm-package-arg@11.0.1 None +7 630 kB npm-cli-ops
npm/npm-pick-manifest@9.0.0 None +10 657 kB npm-cli-ops
npm/object-assign@4.1.1 None 0 5.49 kB sindresorhus
npm/path-scurry@1.10.1 filesystem +2 1.27 MB isaacs
npm/postcss-load-config@4.0.2 environment, unsafe Transitive: filesystem +25 73.6 MB ai
npm/proc-log@3.0.0 None 0 5.21 kB lukekarrys
npm/rollup@4.12.0 environment, filesystem +1 2.43 MB lukastaegert
npm/socks-proxy-agent@8.0.2 network +6 589 kB tootallnate
npm/spdx-correct@3.2.0 None +3 51.4 kB kemitchell
npm/ssri@10.0.5 None +1 323 kB npm-cli-ops
npm/sucrase@3.35.0 Transitive: environment, filesystem, network, shell, unsafe +42 4.59 MB alangpierce
npm/thenify-all@1.6.0 None +2 36.7 kB dead_horse
npm/thenify@3.3.1 None +1 30.1 kB dead_horse
npm/tree-kill@1.2.2 shell 0 7.82 kB wmhilton
npm/ts-interface-checker@0.1.13 None 0 68 kB dsagal2
npm/tsup@7.3.0 environment, eval, filesystem Transitive: network, shell, unsafe +144 296 MB egoist
npm/unique-filename@3.0.0 None +2 17.9 kB lukekarrys
npm/unique-slug@4.0.0 None +1 14.5 kB lukekarrys
npm/validate-npm-package-license@3.0.4 None +4 68 kB kemitchell
npm/validate-npm-package-name@5.0.0 None +3 122 kB lukekarrys
npm/which@4.0.0 environment Transitive: filesystem +1 50.5 kB npm-cli-ops

🚮 Removed packages: npm/@lavamoat/aa@3.1.5, npm/@lavamoat/allow-scripts@2.5.1, npm/@metamask/eslint-config-jest@11.1.0, npm/@metamask/eslint-config-nodejs@11.1.0, npm/@metamask/eslint-config-typescript@11.1.0, npm/@metamask/eslint-config@11.1.0, npm/@npmcli/fs@2.1.2, npm/@npmcli/promise-spawn@6.0.2, npm/@npmcli/run-script@6.0.2, npm/abbrev@1.1.1, npm/agentkeepalive@4.5.0, npm/bin-links@4.0.1, npm/cacache@16.1.3, npm/chokidar@3.5.3, npm/eslint-plugin-es@3.0.1, npm/eslint-plugin-node@11.1.0, npm/has@1.0.3, npm/ip@2.0.1, npm/js-sdsl@4.4.0, npm/make-fetch-happen@10.2.1, npm/minipass-collect@1.0.2, npm/minipass-fetch@2.1.2, npm/node-gyp@9.4.1, npm/nopt@6.0.0, npm/read-package-json-fast@3.0.2, npm/socks-proxy-agent@7.0.0, npm/ssri@9.0.1, npm/unique-filename@2.0.1, npm/unique-slug@3.0.0, npm/which@3.0.1

View full report↗︎

Copy link

socket-security bot commented Feb 26, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@lavamoat/preinstall-always-fail@2.0.0, npm/@npmcli/agent@2.2.1, npm/abbrev@2.0.0, npm/agent-base@7.1.0, npm/debug@2.6.9, npm/esbuild@0.19.12, npm/foreground-child@3.1.1, npm/mz@2.7.0, npm/nopt@7.2.0, npm/normalize-package-data@6.0.0, npm/socks-proxy-agent@8.0.2, npm/source-map@0.8.0-beta.0, npm/tree-kill@1.2.2, npm/tsup@7.3.0, npm/validate-npm-package-name@5.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Feb 26, 2024

@SocketSecurity ignore npm/debug@2.6.9
@SocketSecurity ignore npm/agent-base@7.1.0
@SocketSecurity ignore npm/mz@2.7.0
@SocketSecurity ignore npm/@npmcli/agent@2.2.1
@SocketSecurity ignore npm/socks-proxy-agent@8.0.2

Network access is ok. Not used in production.

@SocketSecurity ignore npm/validate-npm-package-name@5.0.0
@SocketSecurity ignore npm/nopt@7.2.0
@SocketSecurity ignore npm/abbrev@2.0.0
@SocketSecurity ignore npm/source-map@0.8.0-beta.0
@SocketSecurity ignore npm/normalize-package-data@6.0.0

New authors seem ok.

@SocketSecurity ignore npm/foreground-child@3.1.1
@SocketSecurity ignore npm/tree-kill@1.2.2

Shell access ok. Not used in production.

@SocketSecurity ignore npm/esbuild@0.19.12

Network / shell access is expected.

@SocketSecurity ignore npm/tsup@7.3.0

Deprecated is ok. Shouldn't be an issue in our case.

@SocketSecurity ignore npm/@lavamoat/preinstall-always-fail@2.0.0

Script is expected.

@@ -1,4 +1,4 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.

* @MetaMask/devs
* @MetaMask/engineering
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub seems to think this doesn't exist. Does the group need to be added manually to the repo or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I already asked @Gudahtt to do so.

Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CODEOWNERS change has been resolved

@Mrtenz Mrtenz merged commit 361d754 into main Feb 28, 2024
16 checks passed
@Mrtenz Mrtenz deleted the mrtenz/standardise-february-2024 branch February 28, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants