feat: Modify provider RPC error log severity from error to warn
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error middleware injected in the provider-side `json-rpc-engine` was calling `log.error()` (in practice, `log` = `console`) every time it observed a JSON-RPC error response. We received reports that this error log is caught by the monitoring infra of some dapps. It is ultimately the caller's responsibility to handle errors where they call `ethereum.request()`, and they can always `console.error()` at that point themselves. In light of the above, we decrease the severity of our own log statement to `debug`.
legobeat
reviewed
May 29, 2024
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
rekmarks
changed the title
error to debugerror to warn
|
The stretch-goal version of this would be to make logging configurable via some method on the provider object (constructor arguments don't help most of our consumers), but that's definitely a stretch goal. |
legobeat
approved these changes
May 30, 2024
|
@rekmarks Going ahead and merging this to get it into next release FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error middleware injected in the provider-side
json-rpc-enginewas callinglog.error()(in practice,log=console) every time it observed a JSON-RPC error response.We received reports that this error log is caught by the monitoring infra of some dapps. It is ultimately the caller's responsibility to handle errors where they call
ethereum.request(), and they can alwaysconsole.error()at that point themselves. In light of the above, we decrease the severity of our own log statement towarn.