Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip emitting data event for wallet_accountsChanged #73

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Skip emitting data event for wallet_accountsChanged #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/MetamaskInpageProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,23 +171,23 @@ module.exports = class MetamaskInpageProvider extends SafeEventEmitter {
// json rpc notification listener
jsonRpcConnection.events.on('notification', (payload) => {

this.emit('data', payload) // deprecated

const { method, params, result } = payload

if (method === 'wallet_accountsChanged') {
this._handleAccountsChanged(result)
} else if (EMITTED_NOTIFICATIONS.includes(method)) {
return
}

if (EMITTED_NOTIFICATIONS.includes(method)) {
this.emit('data', payload) // deprecated
Gudahtt marked this conversation as resolved.
Show resolved Hide resolved

this.emit('message', {
type: method,
data: params,
})

// deprecated
if (params) {
this.emit('notification', params.result)
}
this.emit('notification', params.result)
}
})

Expand Down