Skip to content

fix: iOS download file.bin alert #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weitingsun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: iOS download file.bin alert #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion apple/RNCWebViewImpl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,11 +973,20 @@ -(void)setKeyboardDisplayRequiresUserAction:(BOOL)keyboardDisplayRequiresUserAct
}

- (void)downloadBase64File:(NSString *)base64String {
// Infer file extension from the data: URL before doing any heavy work.
// For generic application/octet-stream payloads we suppress the download
// entirely (no "Do you want to download File.bin?" alert), since these
// are typically iframe-driven noise rather than user‑initiated downloads.
NSString *fileExtension = [self fileExtensionFromBase64String:base64String];
if ([[fileExtension lowercaseString] isEqualToString:@"bin"]) {
NSLog(@"RNCWebViewImpl: Ignoring generic binary download (File.bin) from data: URL");
return;
}

NSArray *components = [base64String componentsSeparatedByString:@","];
NSString *base64ContentPart = components.lastObject;

NSData *fileData = [[NSData alloc] initWithBase64EncodedString:base64ContentPart options:NSDataBase64DecodingIgnoreUnknownCharacters];
NSString *fileExtension = [self fileExtensionFromBase64String:base64String];
[self showDownloadAlert:fileExtension invokeDownload:^{
NSString *tempFilePath = [NSTemporaryDirectory() stringByAppendingPathComponent:[NSString stringWithFormat:@"File.%@", fileExtension]];
[fileData writeToFile:tempFilePath atomically:YES];
Expand Down
Loading