You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I played around with MetaMask/core#2017 some more and I think we can solve this problem by de-duping. So we don't need this PR.
To answer your question, though, the reason why we saw the build failure on core was due to the fact that the versions of @metamask/utils were different between @metamask/json-rpc-engine (now in core) and this package (json-rpc-engine was now using 8.2.1, rpc-errors was still using 8.1.0). The error was manifested in a difference in JsonRpc* types which were introduced in this PR: MetaMask/utils#136 (released in 8.2.0). Admittedly I can't 100% explain the changes in this PR due to some advanced TypeScript techniques, but in hindsight, they probably should have been marked as breaking.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should unblock MetaMask/core#2017.